Skip to content

fix: View Hierarchy positioning is relative#144

Closed
timfish wants to merge 1 commit intogetsentry:mainfrom
timfish:fix/view-hierarchy-absolute
Closed

fix: View Hierarchy positioning is relative#144
timfish wants to merge 1 commit intogetsentry:mainfrom
timfish:fix/view-hierarchy-absolute

Conversation

@timfish
Copy link
Contributor

@timfish timfish commented Jan 19, 2025

It was not mentioned in the RFC but View Hierarchy positioning is expected to be relative to the parent window.

In Sentry, flutter projects were hard-coded to use absolute positioning but it was not possible to override this for other platforms.

I opened a PR to allow overriding this by including absolute in the rendering_system:

@timfish
Copy link
Contributor Author

timfish commented Jan 20, 2025

Another alternative might be to add a top level positioning property which can be relative or absolute and defaults to relative if not set?

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks!

@timfish timfish marked this pull request as draft April 11, 2025 09:13
@markushi
Copy link
Member

markushi commented Feb 4, 2026

I guess we can close this one in favor of #150, right?

@timfish timfish closed this Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants